Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

more spectral extraction improvements for downstream use #3227

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

more spectral extraction improvements for downstream use #3227

wants to merge 3 commits into from

Conversation

kecnry
Copy link
Member

@kecnry kecnry commented Oct 17, 2024 •
edited
Loading

Description

This pull request implements several more generalizations/improvements so that spectral extraction can be inherited downstream (in lcviz in spacetelescope/lcviz#115 and possibly in rampviz in the future).

These are very minor changes - would it be unreasonable to consider this for the next bugfix release? Shouldn't affect jdaviz configs directly, so probably doesn't need a changelog?

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@kecnry kecnry added bug Something isn't working UI/UX😍 no-changelog-entry-needed changelog bot directive labels Oct 17, 2024
@kecnry kecnry added this to the 4.0.1 milestone Oct 17, 2024
@github-actions github-actions bot added cubeviz plugin Label for plugins common to multiple configurations labels Oct 17, 2024
@kecnry kecnry mentioned this pull request Oct 17, 2024
Draft
9 tasks
@codecov Codecov
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.62%. Comparing base (9a1fe09) to head (3430d1d).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #3227   +/-   ##
=======================================
  Coverage   88.62%   88.62%           
=======================================
  Files         125      125           
  Lines       18775    18775           
=======================================
  Hits        16639    16639           
  Misses       2136     2136

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kecnry kecnry added the 💤backport-v4.0.x on-merge: backport to v4.0.x label Oct 18, 2024
@pllim pllim modified the milestones: 4.0.1, 4.0.2, 4.1 Dec 17, 2024
@rosteen rosteen modified the milestones: 4.1, 4.2 Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rosteen rosteen Awaiting requested review from rosteen rosteen will be requested when the pull request is marked ready for review rosteen is a code owner

@javerbukh javerbukh Awaiting requested review from javerbukh javerbukh will be requested when the pull request is marked ready for review javerbukh is a code owner

@pllim pllim Awaiting requested review from pllim pllim will be requested when the pull request is marked ready for review pllim is a code owner

@bmorris3 bmorris3 Awaiting requested review from bmorris3 bmorris3 will be requested when the pull request is marked ready for review bmorris3 is a code owner

@haticekaratay haticekaratay Awaiting requested review from haticekaratay haticekaratay will be requested when the pull request is marked ready for review haticekaratay is a code owner

@cshanahan1 cshanahan1 Awaiting requested review from cshanahan1 cshanahan1 will be requested when the pull request is marked ready for review cshanahan1 is a code owner

@gibsongreen gibsongreen Awaiting requested review from gibsongreen gibsongreen will be requested when the pull request is marked ready for review gibsongreen is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
bug Something isn't working cubeviz no-changelog-entry-needed changelog bot directive plugin Label for plugins common to multiple configurations UI/UX😍 💤backport-v4.0.x on-merge: backport to v4.0.x
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
3 participants
@kecnry @pllim @rosteen